zynaddsubfx

commit caafd63e7d57a6e78e2ddb9dfff5b85f309bd2c8
parent 0d9496d3793c4dde9fa725fc43119f5f4a4193b3
Author: fundamental <[email protected]>
Date:   Fri,  6 Nov 2015 19:16:05 -0500

Remove Undefined Behavior In LFOParams::Paste

Diffstat:
M
src/Params/LFOParams.cpp
 | 
15
+++++++++++----

1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/Params/LFOParams.cpp b/src/Params/LFOParams.cpp
@@ -142,10 +142,17 @@ void LFOParams::getfromXML(XMLwrapper *xml)
     Pcontinous  = xml->getparbool("continous", Pcontinous);
 }
 
+#define COPY(y) this->y=x.y
 void LFOParams::paste(LFOParams &x)
 {
-    //Avoid undefined behavior
-    if(&x == this)
-        return;
-    memcpy((char*)this, (const char*)&x, sizeof(*this));
+    COPY(Pfreq);
+    COPY(Pintensity);
+    COPY(Pstartphase);
+    COPY(PLFOtype);
+    COPY(Prandomness);
+    COPY(Pfreqrand);
+    COPY(Pdelay);
+    COPY(Pcontinous);
+    COPY(Pstretch);
 }
+#undef COPY