commit f1888dd7f24806f0a694030c90d22f709bc38a09
parent bba479c2ff97a41ee4e5a884328f8daa6891ecef
Author: Steven Atkinson <[email protected]>
Date: Wed, 26 Apr 2023 19:12:10 -0700
Fix learning rate decay (#215)
* Fix learning rate decay
Keep model file version fixed, decoupling from package version.
Add some comments
* Bump package patch version
Diffstat:
4 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/nam/_version.py b/nam/_version.py
@@ -1 +1 @@
-__version__ = "0.5.1"
+__version__ = "0.5.2"
diff --git a/nam/models/_exportable.py b/nam/models/_exportable.py
@@ -12,12 +12,15 @@ from typing import Any, Dict, Optional, Tuple, Union
import numpy as np
-from .._version import __version__
from ..data import np_to_wav
from .metadata import Date, UserMetadata
logger = logging.getLogger(__name__)
+# Model version is independent from package version as of package version 0.5.2 so that
+# the API of the package can iterate at a different pace from that of the model files.
+_MODEL_VERSION = "0.5.1"
+
def _cast_enums(d: Dict[Any, Any]) -> Dict[Any, Any]:
"""
@@ -123,7 +126,7 @@ class Exportable(abc.ABC):
def _get_export_dict(self):
return {
- "version": __version__,
+ "version": _MODEL_VERSION,
"metadata": self._get_non_user_metadata(),
"architecture": self.__class__.__name__,
"config": self._export_config(),
diff --git a/nam/models/metadata.py b/nam/models/metadata.py
@@ -14,6 +14,7 @@ from pydantic import BaseModel
__all__ = ["GearType", "ToneType", "Date", "UserMetadata"]
+# Note: if you change this enum, you need to update the options in easy_colab.ipynb!
class GearType(Enum):
AMP = "amp"
PEDAL = "pedal"
@@ -22,7 +23,7 @@ class GearType(Enum):
PREAMP = "preamp"
STUDIO = "studio"
-
+# Note: if you change this enum, you need to update the options in easy_colab.ipynb!
class ToneType(Enum):
CLEAN = "clean"
OVERDRIVE = "overdrive"
diff --git a/nam/train/gui.py b/nam/train/gui.py
@@ -276,7 +276,7 @@ class _GUI(object):
# If you're poking around looking for these, then maybe it's time to learn to
# use the command-line scripts ;)
lr = 0.004
- lr_decay = 0.05
+ lr_decay = 0.007
seed = 0
# Run it
